Re: [PATCH 03/04] qemu-kvm: Remove the dependency for phys_ram_base
Avi Kivity <[email protected]>
| Newsgroups | org.kernel.vger.kvm-ia64,org.kernel.vger.kvm |
|---|---|
| Message-ID | <[email protected]> |
Zhang, Xiantao wrote: >> >> qemu_get_ram_ptr() returns a pointer. Don't cast it to a ram_addr_t, >> leave it a pointer. >> >> But why not use cpu_physical_memory_write() (or >> cpu_physical_memory_write_rom())? It's much simpler and cleaner. >> > > Good suggestion! I just followed the original logic. Updated the patch. > Xiantao Thanks, applied. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic.