Re: [patch] fix qemu-kvm to build when gdbstub is disabled

Jes Sorensen wrote:
> Avi Kivity wrote:
>> I agree, unless
>>
>> - we want to make gdbstub support configurable (don't see any
>> overwhelming reason for this, but maybe others do)
>> - we want to merge ia64 kvm support upstream, and don't want to impose
>> gdbstub support (though I'd recommend properly implementing gdbstub)
>>
>> In any case, I'm okay with dropping the check upstream and applying
>> the local fixup.
> 
> Hi,
> 
> Here's a patch that fixes the #ifndef to make it the #ifdef as it was
> intended.
> 
> I am quite fine with us trying to drop all the #ifdefs and introduce
> noop wrappers for archs that do not provide the gdbstubs (ie. ia64), but
> to start with we better just fix the #ifndef to make it behave like it
> was originally intended.

As the original change this patch (correctly) fixes broke gdbstub
support in qemu-kvm for all archs + it is still a deviation from
upstream, please take the chance and go for ia64 stubs.

BTW, I'm planning to submit a cleanup patch for CONFIG_GDBSTUB to
upstream soon.

Jan

-- 
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux