Re: [PATCH 02/04] qemu-kvm: Add header files for ia64.
Avi Kivity <[email protected]>
| Newsgroups | org.kernel.vger.kvm-ia64,org.kernel.vger.kvm |
|---|---|
| Message-ID | <[email protected]> |
Jes Sorensen wrote: > Zhang, Xiantao wrote: >> Hi, Jes >> There should be no issue here. You may refer to >> qemu-kvm/kvm/kernel/arch/x86/include/asm/kvm.h, and it also includes >> this stuff. I remebered this stuff was used to solve the issues when >> uses kernel header files in userspace and the author should be Avi:-) >> You know, kernel header may include CONFIG_$ARCH macros but they are >> meaningless in userspace, so needs a way to solve the gap. But anyway >> we can do some cleanup or introduce new ways to solve the issue. Xiantao > > Hi Xiantao, > > I noticed it's in the x86 code as well - but I still think it's silly to > add to the ia64 tree when we don't need it. > > Of course, Avi should fix up his headers too :-) > It's autogenerated; but we do need a cleaner solution. qemu upstream is working on a more inclusive Linux header takeover; we can use that when it's done. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic.