Re: [PATCH] qemu-kvm: Flush icache after dma operations for ia64
Avi Kivity <[email protected]>
| Newsgroups | org.kernel.vger.kvm-ia64,org.kernel.vger.kvm |
|---|---|
| Message-ID | <[email protected]> |
Jes Sorensen wrote: > Ok, > > Trying once more. After spending a couple of hours trying to follow > the QEMU dma codeflow, I have convinced myself Avi is right and those > two functions don't need to do the flushing as they all end up calling > dma_bdrv_cb() which calls dma_brdv_unmap(). I have added a couple > comments to the code, which will hopefully save the next person the > 'pleasure' of trying to figure out this too. > It looks right to me. Xiantao? > access_len -= l; > - } > + } > + dma_flush_range((unsigned long)buffer, > + (unsigned long)buffer + flush_len); > } > Detab your code, please. -- error compiling committee.c: too many arguments to function