Re: [PATCH 04/04] qemu-kvm: other archs should maintain memory

On Mon, 2009-05-04 at 11:25 +0200, Jes Sorensen wrote:
> Avi Kivity wrote:
> > Jes Sorensen wrote:
> >> +int destroy_region_works = 0;
> > 
> > Global name, prefix with kvm_.  Does it actually need to be global?
> 
> Gone, now local to qemu-kvm-x86.c. I moved the initializer into
> kvm_arch_create_context() instead.
> 
> > The header depends on target_phys_addr_t, so it must include whatever 
> > defines it.
> 
> Added an #include "cpu-all.h" which defines it.
> 
> > Missing other archs...
> > 
> > Instead of duplicating this for every arch, you can have a #define that 
> > tells you if you want non-trivial arch definitions, and supply the 
> > trivial definitions in qemu-kvm.h.
> 
> Done, I also added a PPC header file - which may or may not be wanted
> at this point. You can just cut it out if you don't think it should be
> added.

I don't understand the code being moved, but I guess I don't want it, so
your patch is fine with me.

(Wtf are those magic addresses? And not a single comment?? Aren't we
better than this?)

-- 
Hollis Blanchard
IBM Linux Technology Center