RE: [PATCH] qemu-kvm: Flush icache after dma operations for ia64
"Zhang, Xiantao" <[email protected]>
| Newsgroups | org.kernel.vger.kvm-ia64,org.kernel.vger.kvm |
|---|---|
| Message-ID | <706158FABBBA044BAD4FE898A02E4BC201BD6620EC@pdsmsx503.ccr.corp.intel.com> |
Hi, Jes
Have you verified whether it works for you ? You may run kernel build in the guest with 4 vcpus, if it can be done successfully without any error, it should be Okay I think, otherwise, we may need to investigate it further. :)
Xiantao
-----Original Message-----
From: Jes Sorensen [mailto:[email protected]]
Sent: Tuesday, June 02, 2009 6:57 PM
To: Avi Kivity
Cc: Zhang, Xiantao; [email protected]; [email protected]; Hollis Blanchard
Subject: Re: [PATCH] qemu-kvm: Flush icache after dma operations for ia64
Avi Kivity wrote:
> Zhang, Xiantao wrote:
>> Fine to me. But seems the change in qemu_iovec_from_buffer is lost in
>> this patch or that change is also not unnecessary ?
>
> I think the fixed unmap handles that case. Can you test to make sure?
>
Avi and I went through the code and verified that it was all covered by
the unmap case. It was pretty messy to come to the conclusion, which is
why I tried to document it in the code and the patch description.
Cheers,
Jes