RE: [PATCH] KVM: dereference of NULL pointer in set_pal_result()
"Zhang, Xiantao" <[email protected]>
| Newsgroups | org.kernel.vger.kvm-ia64,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <EB8593BCECAB3D40A8248BE0B6400A38315E5831@shzsmsx502.ccr.corp.intel.com> |
For the check "(p && p->exit_reason = EXIT_REASON_PAL_CALL", if p is NULL, the reference about "p->exit_reason = EXIT_REASON_PAL_CALL" won't be checked any more, so no issue here. Xiantao Roel Kluin wrote: > Do not dereference a NULL pointer > > Signed-off-by: Roel Kluin <[email protected]> > --- > arch/ia64/kvm/kvm_fw.c | 6 ++++-- > 1 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/arch/ia64/kvm/kvm_fw.c b/arch/ia64/kvm/kvm_fw.c > index e4b8231..d28494f 100644 > --- a/arch/ia64/kvm/kvm_fw.c > +++ b/arch/ia64/kvm/kvm_fw.c > @@ -75,9 +75,11 @@ static void set_pal_result(struct kvm_vcpu *vcpu, > struct exit_ctl_data *p; > > p = kvm_get_exit_data(vcpu); > - if (p && p->exit_reason = EXIT_REASON_PAL_CALL) { > + if (!p) > + return; > + if (p->exit_reason = EXIT_REASON_PAL_CALL) { > p->u.pal_data.ret = result; > - return ; > + return; > } > INIT_PAL_STATUS_UNIMPLEMENTED(p->u.pal_data.ret); > }