RE: [PATCH] KVM: remove redundant NULL tests
"Zhang, Xiantao" <[email protected]>
| Newsgroups | org.kernel.vger.kvm-ia64,org.kernel.vger.kvm,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <EB8593BCECAB3D40A8248BE0B6400A38355E3BEC@shzsmsx502.ccr.corp.intel.com> |
Bill Davidsen wrote: > Roel Kluin wrote: >> kvm_get_exit_data() cannot return a NULL pointer. >> >> Signed-off-by: Roel Kluin <[email protected]> >> --- >> arch/ia64/kvm/kvm_fw.c | 28 +++++++++++++--------------- >> 1 files changed, 13 insertions(+), 15 deletions(-) >> >> diff --git a/arch/ia64/kvm/kvm_fw.c b/arch/ia64/kvm/kvm_fw.c >> index e4b8231..cb548ee 100644 >> --- a/arch/ia64/kvm/kvm_fw.c >> +++ b/arch/ia64/kvm/kvm_fw.c >> @@ -75,7 +75,7 @@ static void set_pal_result(struct kvm_vcpu *vcpu, >> struct exit_ctl_data *p; >> >> p = kvm_get_exit_data(vcpu); >> - if (p && p->exit_reason = EXIT_REASON_PAL_CALL) { >> + if (p->exit_reason = EXIT_REASON_PAL_CALL) { >> p->u.pal_data.ret = result; >> return ; >> } > [___etc___] > > Clearly the original author thought that there was a path where > kvm_exit_data could return a NULL pointer, was that ever possible? Originally, we planed to allocate the exit_data dynamically, but considering some constrains, the exit_data is allocated statically, so the check for NULL is useless now. Xiantao