Re: [PATCH] KVM: fix the handling of dirty bitmaps to avoid overflows
Avi Kivity <[email protected]> Tue, 13 Apr 2010 07:05:38 +0000
| Newsgroups | org.kernel.vger.kvm-ia64,org.kernel.vger.kvm,org.kernel.vger.kvm-ppc |
|---|---|
| Message-ID | <[email protected]> |
On 04/13/2010 10:03 AM, Takuya Yoshikawa wrote: >> It's better to limit memory slots to something that can be handled by >> everything, then. 2^31 pages is plenty. Return -EINVAL if the slot is >> too large. > > > I agree with that, so we make this patch pending to fix like that? > -- or should make a new patch based on this patch? We need a new patch to block oversize memory slots. The current patch can come on top (but now page numbers fit inside an int, so it is just a cleanup, not a bugfix). -- Do not meddle in the internals of kernels, for they are subtle and quick to panic.