Re: [PATCH 0/7] Consolidate vcpu ioctl locking
Avi Kivity <[email protected]> Thu, 13 May 2010 12:29:51 +0000
| Newsgroups | org.kernel.vger.kvm-ia64,org.kernel.vger.kvm,org.kernel.vger.kvm-ppc |
|---|---|
| Message-ID | <[email protected]> |
On 05/13/2010 03:18 PM, Alexander Graf wrote: > >> [PATCH 0/7] Consolidate vcpu ioctl locking >> >> In general, all vcpu ioctls need to take the vcpu mutex, but each one does it >> (or not) individually. This is cumbersome and error prone. >> >> This patchset moves all locking to a central place. This is complicated >> by the fact that ppc's KVM_INTERRUPT and s390's KVM_S390_INTERRUPT break >> the convention and need to run unlocked. >> > Why is the x86 non-kernel-pic path different? > Userspace issues the ioctl from a vcpu thread. It has to, btw, since whether an interrupt can be injected or not depends on vcpu-synchronous registers: eflags.if and tpr/cr8. -- error compiling committee.c: too many arguments to function