Re: [PATCH 10/17] arch/ia64/kvm: Add missing spin_unlock

Avi Kivity <[email protected]> Thu, 27 May 2010 13:20:25 +0000

Newsgroups	org.kernel.vger.kvm-ia64,org.kernel.vger.kernel-janitors,org.kernel.vger.kvm,org.kernel.vger.linux-ia64,org.kernel.vger.linux-kernel
Message-ID	<[email protected]>

On 05/26/2010 06:57 PM, Julia Lawall wrote:
> From: Julia Lawall<[email protected]>
>
> Add a spin_unlock missing on the error path.
>
> The semantic match that finds this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> //<smpl>
> @@
> expression E1;
> @@
>
> * spin_lock(E1,...);
>    <+... when != E1
>    if (...) {
>      ... when != E1
> *   return ...;
>    }
>    ...+>
> * spin_unlock(E1,...);
> //</smpl>
>
>    

Applied, thanks.

-- 
error compiling committee.c: too many arguments to function