Re: [PATCH v1 2/4] KVM: stats: Update doc for histogram statistics
Jing Zhang <[email protected]>
| Newsgroups | org.kernel.vger.kvm-ppc,org.kernel.vger.kvm |
|---|---|
| Message-ID | <CAAdAUtj-e=bvZ07iH7r7eqg4Fy-KaPPgQiMHHVOh8EL4GfUJqA@mail.gmail.com> |
On Wed, Jul 28, 2021 at 5:42 AM Paolo Bonzini <[email protected]> wrote: > > On 08/07/21 01:31, David Matlack wrote: > >> + > >> +8.35 KVM_CAP_STATS_BINARY_FD > >> +---------------------------- > >> + > >> +:Architectures: all > >> + > >> +This capability indicates the feature that userspace can get a file descriptor > >> +for every VM and VCPU to read statistics data in binary format. > > This should probably be in a separate patch with a Fixes tag. > > Generally this chapter (which is probably incomplete, though) only > includes capabilities for which KVM_CHECK_EXTENSION can return a value > other than 0 or 1. So there is no need to include KVM_CAP_STATS_BINARY_FD. Got it. Will drop this change. > > Paolo > Thanks, Jing