Re: [PATCH kernel v3] KVM: PPC: Merge powerpc's debugfs entry content into generic entry

Hi Alexey,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on powerpc/topic/ppc-kvm]
[also build test ERROR on v5.16-rc5]
[cannot apply to next-20211214]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Alexey-Kardashevskiy/KVM-PPC-Merge-powerpc-s-debugfs-entry-content-into-generic-entry/20211215-094051
base:   https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git topic/ppc-kvm
config: powerpc-randconfig-r003-20211214 (https://download.01.org/0day-ci/archive/20211215/[email protected]/config)
compiler: powerpc-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/bb4c492cb444748049b4392c1d6f97ca5c82f846
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Alexey-Kardashevskiy/KVM-PPC-Merge-powerpc-s-debugfs-entry-content-into-generic-entry/20211215-094051
        git checkout bb4c492cb444748049b4392c1d6f97ca5c82f846
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=powerpc SHELL=/bin/bash arch/powerpc/kvm/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>

All errors (new ones prefixed by >>):

>> arch/powerpc/kvm/e500.c:498:32: error: initialization of 'int (*)(struct kvm_vcpu *, struct dentry *)' from incompatible pointer type 'void (*)(struct kvm_vcpu *, struct dentry *)' [-Werror=incompatible-pointer-types]
     498 |         .create_vcpu_debugfs = kvmppc_create_vcpu_debugfs_e500,
         |                                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   arch/powerpc/kvm/e500.c:498:32: note: (near initialization for 'kvm_ops_e500.create_vcpu_debugfs')
   cc1: all warnings being treated as errors

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for HOTPLUG_CPU
   Depends on SMP && (PPC_PSERIES || PPC_PMAC || PPC_POWERNV || FSL_SOC_BOOKE
   Selected by
   - PM_SLEEP_SMP && SMP && (ARCH_SUSPEND_POSSIBLE || ARCH_HIBERNATION_POSSIBLE && PM_SLEEP


vim +498 arch/powerpc/kvm/e500.c

   483	
   484	static struct kvmppc_ops kvm_ops_e500 = {
   485		.get_sregs = kvmppc_core_get_sregs_e500,
   486		.set_sregs = kvmppc_core_set_sregs_e500,
   487		.get_one_reg = kvmppc_get_one_reg_e500,
   488		.set_one_reg = kvmppc_set_one_reg_e500,
   489		.vcpu_load   = kvmppc_core_vcpu_load_e500,
   490		.vcpu_put    = kvmppc_core_vcpu_put_e500,
   491		.vcpu_create = kvmppc_core_vcpu_create_e500,
   492		.vcpu_free   = kvmppc_core_vcpu_free_e500,
   493		.init_vm = kvmppc_core_init_vm_e500,
   494		.destroy_vm = kvmppc_core_destroy_vm_e500,
   495		.emulate_op = kvmppc_core_emulate_op_e500,
   496		.emulate_mtspr = kvmppc_core_emulate_mtspr_e500,
   497		.emulate_mfspr = kvmppc_core_emulate_mfspr_e500,
 > 498		.create_vcpu_debugfs = kvmppc_create_vcpu_debugfs_e500,
   499	};
   500	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]