Re: [PATCH kernel v4] KVM: PPC: Merge powerpc's debugfs entry content into generic entry

>>> -	xive->dentry = debugfs_create_file(name, S_IRUGO, arch_debugfs_dir,
>>> +	xive->dentry = debugfs_create_file("xive", S_IRUGO, xive->kvm->debugfs_dentry,
>>>    					   xive, &xive_debug_fops);
>>
>> The KVM XIVE device implements a "xics-on-xive" interface, the XICS hcalls
>> on top of the XIVE native PowerNV (OPAL) interface, and ...
>>
>>> -	pr_debug("%s: created %s\n", __func__, name);
>>> -	kfree(name);
>>> +	pr_debug("%s: created\n", __func__);
>>>    }
>>>    
>>>    static void kvmppc_xive_init(struct kvm_device *dev)
>>> diff --git a/arch/powerpc/kvm/book3s_xive_native.c b/arch/powerpc/kvm/book3s_xive_native.c
>>> index 99db9ac49901..e86f5b6c2ae1 100644
>>> --- a/arch/powerpc/kvm/book3s_xive_native.c
>>> +++ b/arch/powerpc/kvm/book3s_xive_native.c
>>> @@ -1259,19 +1259,10 @@ DEFINE_SHOW_ATTRIBUTE(xive_native_debug);
>>>    
>>>    static void xive_native_debugfs_init(struct kvmppc_xive *xive)
>>>    {
>>> -	char *name;
>>> -
>>> -	name = kasprintf(GFP_KERNEL, "kvm-xive-%p", xive);
>>> -	if (!name) {
>>> -		pr_err("%s: no memory for name\n", __func__);
>>> -		return;
>>> -	}
>>> -
>>> -	xive->dentry = debugfs_create_file(name, 0444, arch_debugfs_dir,
>>> +	xive->dentry = debugfs_create_file("xive", 0444, xive->kvm->debugfs_dentry,
>>>    					   xive, &xive_native_debug_fops);
>>
>> ... the KVM XIVE *native* device implements a "xive" interface", the one
>> using MMIOs for interrupt management.
>>
>> May be it's worth making the difference in the user interface ?
> 
> 
> The content of these xive files is quite different so I kept the same
> name as before, I can change if you think it is worth it, should I? 

It's not very important. The contents differ anyhow.

> You
> are probably the only person who looked at it recently (or ever?) :) Thanks,

and you just did ! :)

Cheers,

C.