Re: [PATCH v3 3/6] KVM: PPC: Don't use pr_emerg when mmio emulation fails
Fabiano Rosas <[email protected]>
| Newsgroups | org.kernel.vger.kvm-ppc,org.ozlabs.lists.linuxppc-dev |
|---|---|
| Message-ID | <[email protected]> |
Nicholas Piggin <[email protected]> writes: > Excerpts from Fabiano Rosas's message of January 8, 2022 7:00 am: >> If MMIO emulation fails we deliver a Program interrupt to the >> guest. This is a normal event for the host, so use pr_info. >> >> Signed-off-by: Fabiano Rosas <[email protected]> >> --- > > Should it be rate limited to prevent guest spamming host log? In the > case of informational messages it's always good if it gives the > administrator some idea of what to do with it. If it's normal > for the host does it even need a message? If yes, then identifying which > guest and adding something like "(this might becaused by a bug in guest > driver)" would set the poor admin's mind at rest. I'll drop this message then and improve the other one that is emitted earlier at the emulation code.