Re: [PATCH v3 4/6] kvm powerpc/book3s-apiv2: Introduce kvm-hv specific PMU

Hi Athira,

Thanks for reviewing this patch series. My responses to your review
comment inline below:


Athira Rajeev <[email protected]> writes:

>> On 23 Jan 2025, at 5:37=E2=80=AFPM, Vaibhav Jain <[email protected]>=
 wrote:
>>=20
>> Introduce a new PMU named 'kvm-hv' to report Book3s kvm-hv specific
<snip>
>
> Hi Vaibhav
>
> All PMU specific code is under =E2=80=9Carch/powerpc/perf in the kernel s=
ource. Here since we are introducing a kvm-hv specific PMU, can we please h=
ave it in arch/powerpc/perf ?

Is it common convention to put PMU specific code in
arch/powerpc/perf across ppc achitecture variants ? If its there can you
please mention the reasons behind it.

Also the code for this PMU, will be part of kvm-hv kernel module as it
utilizes the functionality implemented there. Moving this PMU code to
arch/powerpc/perf will need this to be converted in yet another new
kernel module, adding a dependency to kvm-hv module and exporting a
bunch of functionality from kvm-hv. Which looks bit messy to me

<snip>

--=20
Cheers
~ Vaibhav