Re: [PATCH v5 37/49] Documentation: KVM: Add KVM_DEV_ARM_VGIC_GRP_IRS_REGS to VGICv5 docs

[email protected]
Newsgroups org.kernel.vger.kvm,dev.linux.lists.kvmarm
Message-ID <[email protected]>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing indentation for the KVM_DEV_ARM_VGIC_GRP_IRS_REGS group breaks the document's list structure.
--

--- Patch [37]: [PATCH v5 37/49] Documentation: KVM: Add KVM_DEV_ARM_VGIC_GRP_IRS_REGS to VGICv5 docs ---
commit e5dffc46ed9c5cdaecdbb49991374d8f99bfa132
Author: Sascha Bischoff <[email protected]>

Documentation: KVM: Add KVM_DEV_ARM_VGIC_GRP_IRS_REGS to VGICv5 docs

This commit documents the KVM_DEV_ARM_VGIC_GRP_IRS_REGS attribute group used
to read and write the virtual IRS's MMIO register state. It provides a
GICv5-specific interface using IRS terminology.

> diff --git a/Documentation/virt/kvm/devices/arm-vgic-v5.rst b/Documentation/virt/kvm/devices/arm-vgic-v5.rst
> index 7e41d6699538f..6dd3ff555ba02 100644
> --- a/Documentation/virt/kvm/devices/arm-vgic-v5.rst
> +++ b/Documentation/virt/kvm/devices/arm-vgic-v5.rst
> @@ -149,3 +149,50 @@ Groups:
>      -EBUSY   VCPU is running, or write attempted after a VCPU has run
>      -EINVAL  Invalid mpidr or register value supplied
>      =======  =============================================================
> +
> +
> +KVM_DEV_ARM_VGIC_GRP_IRS_REGS

[Severity: Low]
This isn't a bug, but does this group name need to be indented by two spaces?

Being flush left breaks the list structure under the "Groups:" section. This
will cause the entry to be rendered as a top-level paragraph rather than a
list item in the generated HTML documentation.

> +    Attributes:

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=37
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.