Re: [GIT PULL] KVM (mostly s390) fixes for Linux 7.2-rc7
Sean Christopherson <[email protected]>
| Newsgroups | org.kernel.vger.kvm,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On Fri, Aug 07, 2026, Paolo Bonzini wrote: > Il ven 7 ago 2026, 19:07 Sean Christopherson <[email protected]> ha scritto: > > On Fri, Aug 07, 2026, Paolo Bonzini wrote: > > I don't care _that_ much about the code itself, though I still think the out-param > > is all kinds of ugly. I'm not at all ok with doing so silently > > > > and without what I would consider an honest attempt to address review feedback. > > Sorry about that, but again - I waited two weeks and got no reply to > https://lore.kernel.org/all/CABgObfbDE+=ir_phPC+9sVYnNXur6dFx6oAfEGSnCbrOqFoyVA@mail.gmail.com/. > I consider two weeks of wait, on a review that so far had been > exclusively about taste, to *be* an honest attempt to gather the next > round of feedback (which never came). Heh, and I was waiting for a response to Yosry's thread: https://lore.kernel.org/all/CAO9r8zODKgCcjTBK=P6BuXBBZRoOAFMeRJU8BmkWL-BCX2LoBw@mail.gmail.com I also didn't prioritize responding (or even digging deeper) because I wasn't expecting the patch to get fast-tracked to 7.2. It's not tagged for stable, the code has existed for years, and at least for me, nothing else suggested it needed to go in *now*. It doesn't help that the commit showed up in kvm/master late yesterday; the first heads up I got that you were applying the patch as-is was this pull request. In other words, it's the lack of communication that's frustrating. Even a simple "Hey, I'm applying this unless someone screams" would have sufficed. > If you had proposed the above small patch, for example, it would have > been a completely different thing. Heh, if only past me had realized we could have done that. I guess the desire to prove someone "wrong" on the internet is the mother of all invention? :-D > I would have taken your suggestion immediately. > > Paolo > > > > > [1] https://lore.kernel.org/all/[email protected] > > [2] https://lore.kernel.org/all/CAO9r8zM=Mb=eTEFGF0G-POvwwbSr7e8SN6zcDp=GstzKtBKcow@mail.gmail.com > > [3] https://lore.kernel.org/all/CAO9r8zMopB=YKXs5pkQmPf9uHKE0P0XORcNbc60AWXTusuY3tg@mail.gmail.com > > >