Re: [PATCH v14 09/22] KVM: selftests: Expose functions to get default sregs values
Xiaoyao Li <[email protected]>
| Newsgroups | org.kernel.vger.kvm,dev.linux.lists.linux-coco,org.kernel.vger.linux-kernel,org.kernel.vger.linux-kselftest |
|---|---|
| Message-ID | <[email protected]> |
On 8/14/2026 8:44 AM, Edgecombe, Rick P wrote: > On Wed, 2026-07-22 at 23:13 +0000, Lisa Wang wrote: >> >> +#ifndef NUM_INTERRUPTS >> +#define NUM_INTERRUPTS 256 >> +#endif >> + > > Is this necessary for this patch? I see why to extract > kvm_get_default_idt_limit() because now it's used twice. But why extract this > define too? kvm_get_default_idt_limit() uses NUM_INTERRUPTS, and kvm_get_default_idt_limit() is extracted as a helper from .c file to .h file. Shouldn't the define of NUM_INTERRUPTS be moved together?