[PATCH v8 0/8] KVM: x86/pmu: Add hardware Topdown metrics support
Zide Chen <[email protected]>
| Newsgroups | org.kernel.vger.kvm,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
The Topdown Microarchitecture Analysis (TMA) method is a structured approach for identifying performance bottlenecks in out-of-order processors. Currently, guests support the TMA method by collecting Topdown events using GP counters, which may trigger multiplexing. To free up scarce GP counters, eliminate multiplexing-induced skew, and obtain coherent Topdown metric ratios, it is desirable to expose fixed counter 3 and the IA32_PERF_METRICS MSR to guests. Several attempts have been made to virtualize this under the legacy vPMU model [1][2][3], but they were unsuccessful. With the new mediated vPMU, enabling TMA support in guests becomes much simpler. It avoids invasive changes to the perf core, eliminates CPU pinning and fixed-counter affinity issues, and reduces the large overhead of trapping and emulating MSR accesses. [1] https://lore.kernel.org/kvm/[email protected]/ [2] https://lore.kernel.org/all/[email protected]/T/ [3] https://lwn.net/ml/linux-kernel/[email protected]/ Tested on a Sapphire Rapids. Without this series, only raw topdown.*_slots events work in the guest, and metric events (e.g. cpu/topdown-bad-spec/) are not available. With this series, metric events are visible in the guest. Run this command on both host and guest: $ perf stat --topdown --no-metric-only -- taskset -c 2 perf bench sched messaging Host results: Total time: 1.500 [sec] Performance counter stats for 'taskset -c 2 perf bench sched messaging': 4,266,060,558 TOPDOWN.SLOTS:u # 32.0 % tma_frontend_bound # 5.2 % tma_bad_speculation 588,397,905 topdown-retiring:u # 13.8 % tma_retiring # 49.0 % tma_backend_bound 1,376,283,990 topdown-fe-bound:u 2,096,827,304 topdown-be-bound:u 217,425,841 topdown-bad-spec:u 5,050,520 INT_MISC.UOP_DROPPING:u Rebased to kvm-x86/next: 1b731e5ded480bd1 v8 changes: - patch 5/8: Intercept global ctrl MSR if host supports PerfMetrics but not enabled in the guest. - patch 3/9: Remove include "cpuid.h" from pmu_intel.h. - Drop patch v7 7/9 to audit CPU RDPMC encodings. v7 changes: - Add "reviewed-by" tags. - patch 5/8: Optimize bit 48 handling in global_status_rsvd; document the PERF_METRICS/FC3 write-order exception; add nested_vmx_merge_msr_bitmaps_rw(). - patch 7/9: new patch to restrict RDPMC passthrough to known CPUs. - patch 9/9: Use RDPMC instead of RDMSR in PERF_METRICS sanity test. v6 changes: - patch 6/8: New patch to refactor rdpmc emulation code. - patch 7/8: More strict handling of RDPMC ECX argument. - patch 8/8: Move perf metrics out of test_arch_events(). - patch 2/8: Minor fix of comments. v5 changes: - patch 3,5,6/7: new patches to handle RDPMC on metrics. - patch 6/7: remove host_initiated check. v4 changes: - patch 3/4: Remove WARN_ON_ONCE() and simply reject the guest accesses by checking host_initiated. (Sashiko) - patch 3/4: Passthru MSR_PERF_METRICS only if has_mediated_pmu is true. (Sashiko) v3 changes: - patch 2/4: Move the non-contiguous counter filter code to pmu.c (Dapeng) - patch 3/4: Replace WARN_ON() with WARN_ON_ONCE(). (Dapeng) - patch 4/4: Change abs() with explicit bounds (sum >= 0xfd && sum <= 0x102). - Minor comment cleanups. v2 changes: - As suggested by Dapeng, implement a new selftest patch. - Don't advertise fixed counter 3 if the host doesn't support it. - Minor change in patch 1 to remove a magic number. v7: https://lore.kernel.org/kvm/[email protected]/ v6: https://lore.kernel.org/kvm/[email protected]/T/#t v5: https://lore.kernel.org/kvm/[email protected]/ v4: https://lore.kernel.org/kvm/[email protected]/ v3: https://lore.kernel.org/kvm/[email protected]/T/#t v2: https://lore.kernel.org/kvm/[email protected]/T/#u v1: https://lore.kernel.org/kvm/[email protected]/T/#t QEMU: https://lore.kernel.org/qemu-devel/[email protected]/ Dapeng Mi (2): KVM: x86/pmu: Support Intel fixed counter 3 on mediated vPMU KVM: x86/pmu: Support PERF_METRICS MSR in mediated vPMU Mingwei Zhang (1): KVM: x86/pmu: Snapshot host IA32_PERF_CAPABILITIES in kvm_host Zide Chen (5): KVM: x86/pmu: Do not map fixed counters >= 3 to generic perf events KVM: x86/pmu: Rename and move vcpu_get_perf_capabilities() to pmu.h KVM: x86/pmu: Move RDPMC emulation into per-vendor callbacks KVM: x86/pmu: Emulate RDPMC on performance metrics KVM: selftests: Add PERF_METRICS and fixed counter 3 tests arch/x86/include/asm/kvm-x86-pmu-ops.h | 2 +- arch/x86/include/asm/kvm_host.h | 4 +- arch/x86/include/asm/msr-index.h | 1 + arch/x86/kvm/msrs.c | 10 +- arch/x86/kvm/pmu.c | 36 +++++-- arch/x86/kvm/pmu.h | 17 +++- arch/x86/kvm/svm/pmu.c | 13 ++- arch/x86/kvm/vmx/nested.c | 2 + arch/x86/kvm/vmx/pmu_intel.c | 93 ++++++++++++++----- arch/x86/kvm/vmx/pmu_intel.h | 12 +-- arch/x86/kvm/vmx/vmx.c | 15 +-- arch/x86/kvm/x86.c | 4 + tools/arch/x86/include/asm/msr-index.h | 1 + tools/testing/selftests/kvm/include/x86/pmu.h | 3 + .../selftests/kvm/x86/pmu_counters_test.c | 90 +++++++++++++++++- 15 files changed, 239 insertions(+), 64 deletions(-) -- 2.55.0