Re: [PATCH v2 4/4] s390/vfio-ap: Use AP_DOMAINS for adm_add bitmap size in vfio_ap_mdev_cfg_add()
| Newsgroups | org.kernel.vger.kvm,org.kernel.vger.linux-s390 |
|---|---|
| Message-ID | <[email protected]> |
> Domain and control domain bitmaps are sized by the AP_DOMAINS constant, not > AP_DEVICES. The two constants are both 256 today so there is no functional > impact, but using the wrong constant is inconsistent with every operation > on aqm/adm bitmaps. > > Use AP_DOMAINS to keep the code consistent and correct in case > the two constants ever diverge. > > Note: > This patch was submitted in response to a sashiko review comment pointing > out there are other functions besides vfio_ap_mdev_cfg_add(), so there are > fixes included here for those also. The subject line was kept the same > since this is in v2 of this patch. > > Signed-off-by: Anthony Krowiak <[email protected]> Sashiko has reviewed this patch and found no issues. It looks great! -- Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=4