Re: [PATCH v1 4/4] ACPI: video: Use acpi_dev_get_pci_dev() instead of acpi_get_pci_dev()
Andy Shevchenko <[email protected]>
| Newsgroups | org.kernel.vger.linux-acpi,org.kernel.vger.linux-kernel,org.kernel.vger.linux-pci |
|---|---|
| Organization | Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo |
| Message-ID | <[email protected]> |
On Wed, Jul 15, 2026 at 05:21:23PM +0200, Rafael J. Wysocki wrote: > In acpi_video_bus_check() and find_video(), simply replace > acpi_get_pci_dev() with acpi_dev_get_pci_dev() that can be used > in both places because the ACPI device needed to do the lookup is > available. > > In acpi_video_dev_register_backlight(), instead of doing a parent ACPI > handle lookup based on the handle of an ACPI device that is already > available, pass that ACPI device to acpi_dev_parent() which is much > more straightforward and pass the return value of the latter directly > to acpi_dev_get_pci_dev() to get the PCI device associated with it. > That allows local variable acpi_parent to be eliminated. Reviewed-by: Andy Shevchenko <[email protected]> ... > +++ b/drivers/acpi/video_detect.c > if (acpi_dev && !acpi_match_device_ids(acpi_dev, video_ids)) { > - dev = acpi_get_pci_dev(handle); > + dev = acpi_dev_get_pci_dev(acpi_dev); This likely needs to be rebased on top of the series I sent? -- With Best Regards, Andy Shevchenko