Re: [PATCH 2/4] drivers/misc: add Goodix GXFP5130 eSPI fingerprint sensor driver
Greg KH <[email protected]>
| Newsgroups | org.kernel.vger.linux-acpi,org.kernel.vger.linux-gpio,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <2026071828-blunt-survivor-834f@gregkh> |
On Sat, Jul 18, 2026 at 11:14:29AM +0300, Metehan Günen wrote:
> --- a/drivers/misc/Kconfig
> +++ b/drivers/misc/Kconfig
> @@ -651,4 +651,6 @@ source "drivers/misc/mchp_pci1xxxx/Kconfig"
> source "drivers/misc/keba/Kconfig"
> source "drivers/misc/amd-sbi/Kconfig"
> source "drivers/misc/rp1/Kconfig"
> +source "drivers/misc/gxfp5130/Kconfig"
> +
Why add this extra line?
> endmenu
> diff --git a/drivers/misc/Makefile b/drivers/misc/Makefile
> index fed47c767..e85c68aa1 100644
> --- a/drivers/misc/Makefile
> +++ b/drivers/misc/Makefile
> @@ -74,3 +74,5 @@ obj-$(CONFIG_MCHP_LAN966X_PCI) += lan966x-pci.o
> obj-y += keba/
> obj-y += amd-sbi/
> obj-$(CONFIG_MISC_RP1) += rp1/
> +
> +obj-$(CONFIG_GXFP5130) += gxfp5130/
Same here, why the extra line?
> + gxfp_trace_logf("cmd_timeout req=0x%02x expect=0x%02x tries=%u",
> + req->req_cmd, req->expect_cmd, req->tries ? req->tries : 1);
Please do not roll your own tracing functions, use the in-kernel ones
instead.
thanks,
greg k-h