Re: [PATCH v3 04/10] ACPI: extlog: Avoid populating software AER metadata from raw hardware buffer
Alison Schofield <[email protected]>
| Newsgroups | org.kernel.vger.linux-acpi,org.kernel.vger.linux-cxl |
|---|---|
| Message-ID | <[email protected]> |
On Fri, Jul 17, 2026 at 09:16:41AM -0700, Dave Jiang wrote: > sashiko-bot flagged that casting the raw aer_info buffer fills > software-only AER metadata with hardware data, driving an out-of-bounds > read. > > extlog_print_pcie() casts pcie_err->aer_info directly to struct > aer_capability_regs *. That struct embeds struct pcie_tlp_log, whose > software-only header_len and flit fields sit at offset 84, within the > 96-byte aer_info buffer, so the cast fills them with raw hardware data. > pcie_print_tlp_log() uses flit and header_len to bound a loop over the > dw[] array, so a large header_len walks past its end. > > Copy aer_info into a zeroed local struct aer_capability_regs and clear > header_len and flit before passing it on. > > Reported-by: [email protected] > Fixes: e778ffefa34d ("ACPI: extlog: Trace CPER PCI Express Error Section") > Link: https://lore.kernel.org/linux-cxl/[email protected]/ > Assisted-by: Claude:claude-sonnet-4-6 > Signed-off-by: Dave Jiang <[email protected]> Reviewed-by: Alison Schofield <[email protected]>