Re: [PATCH] ACPI: bus: Avoid misleading _OSC missing-feature errors

Saverio Miroddi <[email protected]>
Newsgroups org.kernel.vger.linux-acpi,org.kernel.vger.linux-kernel
Message-ID <[email protected]>
Hi!

Yes, that's my understanding, with one qualification: we can only infer this from the returned buffer.

The returned capability mask acknowledges every capability requested by OSPM, while OSC_CAPABILITIES_MASK_ERROR says that at least one requested bit was cleared. Since the requested and returned masks are identical, those two parts of the response are inconsistent. The protocol-visible result acknowledges all requested capabilities, so the status bit appears to be a firmware bug.

I'll clarify this in the comment.

For the logging, I'll keep "_OSC: errors while processing control request" for every error return and condition only "_OSC: some features may be missing". That preserves the firmware error report without claiming that capabilities were removed.

Best,
Saverio
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.