Re: [PATCH] x86/topo: Map vendor CPU types to generic Linux such types
Borislav Petkov <[email protected]>
| Newsgroups | org.kernel.vger.linux-acpi,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <20260722195105.GEamEfKQIPgWp4HiBk@fat_crate.local> |
On Wed, Jul 22, 2026 at 12:22:11PM -0700, Pawan Gupta wrote:
> Unless I am misreading, TOPO_CPU_TYPE_ANY is introduced in this patch.
> X86_*_ANY in x86_match_cpu() are much needed wildcards, I dont really
> understand why x86_topology_cpu_type needs to carry a wildcard. It should
> reflect the true state, PERFORMANCE, EFFICIENCY or UNKNOWN.
>
> Between ANY and UNKNOWN, I would prefer UNKNOWN when CPU did not report a
> type.
Because X86_CPU_TYPE_ANY is already there and it is 0 and TOPO_CPU_TYPE_ANY is
supposed to be the same and mirror it.
Did you even read my mail where I explain that we don't do multiple things in
one patch?
> Ya. If need be, a mask of each possible cpu_type can be built for
> dispatching work selectively.
Instead of doing the completely sensible thing and keeping a per-CPU type?
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette