Re: [PATCH v2 4/5] platform/x86: int3472: Release ACPI objects using __free()

Sakari Ailus <[email protected]> Tue, 25 Aug 2026 15:04:31 +0300

Newsgroups	org.kernel.vger.linux-acpi,org.kernel.vger.linux-media,org.kernel.vger.platform-driver-x86
Organization	Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo
Message-ID	<[email protected]>

Hi Rafael,

Thank you for the review.

On Tue, Aug 25, 2026 at 01:54:28PM +0200, Rafael J. Wysocki (Intel) wrote:
> On Mon, Aug 24, 2026 at 11:13 PM Sakari Ailus
> <[email protected]> wrote:
> >
> > Use __free() to release ACPI objects received from
> > acpi_evaluate_dsm_typed() without explicit ACPI_FREE().
> 
> Well, the benefit of doing so is not entirely clear to me.
> 
> At least there is more overhead in the new code, or am I mistaken?

It becomes possible to simplify error handling mid-function. See the 5th
patch -- perhaps squashing this with that would make this more visible?

-- 
Regards,

Sakari Ailus