Re: [PATCH v2 3/5] ACPI: Support __free() from cleanup.h for ACPI objects

On Tue, Aug 25, 2026 at 2:07 PM Sakari Ailus
<[email protected]> wrote:
>
> Hi Rafael,
>
> On Tue, Aug 25, 2026 at 01:51:18PM +0200, Rafael J. Wysocki (Intel) wrote:
> > On Mon, Aug 24, 2026 at 11:13 PM Sakari Ailus
> > <[email protected]> wrote:
> > >
> > > Use DEFINE_FREE() to allow ACPI objects to be released automatically.
> >
> > But at least some of them are allocated by ACPICA functions like
> > acpi_evaluate_object() and so they have no proper constructors.
>
> You could still assign the return buffer to a local variable. It's not
> ideal API-wise though.

Exactly.

> I'm not quite sure what was the point you wanted to make but I reckon this
> wasn't an ack. :-)

Using the _FREE with variables that are not initialized through a
constructor is questionable, so this is generally not particularly
clean.

There is no cleanup.h in ACPICA that is a more traditional C code
base, so mixing up ACPICA code, which ACPI_FREE() is strictly
speaking, with cleanup.h stuff is not particularly straightforward
IMV.  I'd rather not do it.