Re: [PATCH v3 2/3] platform/x86: int3472: Fix uninitialised variable warning

Hi Ricardo,

Thanks for the review.

On Tue, Aug 25, 2026 at 11:04:51PM +0200, Ricardo Ribalda Delgado wrote:
> nits:
> 
> It would be nice to have the error message that it is fixed in the
> commit message (also for 1/3)

There's actually a compiler warning on this, too. I'll reword this being:

Fix a compiler warning about an uninitialised err_msg variable by printing
the error where it is handled:

drivers/platform/x86/intel/int3472/discrete.c:440:24: warning: ‘err_msg’ may be used uninitialized [-Wmaybe-uninitialized]
  440 |                 return dev_err_probe(int3472->dev, ret, err_msg);

> 
> Would you consider adding a Fixes? This patch fixes a compilation
> error (with the right kernel config)

Fixes: 5de691bffe57 ("platform/x86: Add intel_skl_int3472 driver")
Cc: stable

It seems it's always been there but I think it's a false positive: the
compiler probably just can't figure out err_msg is unused if ret is
non-zero.

-- 
Regards,

Sakari Ailus