Re: [PATCH v2] ACPI: glue: Reduce debug noise from acpi_device_notify()

On Sat, Sep 5, 2026 at 9:00 AM Andy Shevchenko
<[email protected]> wrote:
>
> On Fri, Sep 04, 2026 at 05:44:55PM +0200, Rafael J. Wysocki wrote:
>
> > When debug is enabled in the ACPI glue code that handles binding
> > devices to ACPI companions, acpi_device_notify() produces a lot of
> > message noise related to devices that have no ACPI companions.
> >
> > Reduce that noise by checking the most obvious case, ACPI device
> > objects, directly and returning from acpi_device_notify() in that
> > case without printing any debug messages.  Also avoid printing a
> > debug message when there is no matching ACPI bus type definition for
> > the given device, which is the case for the vast majority of devices.
> >
> > Additionally, make the debug messages that get printed more informative
> > and change the format prefix to "ACPI/glue", so it is easier to filter
> > these messages.
>
> You are quick :-) But the comment I gave against v1 still stays here.
> (TL;DR: I expect to see "ACPI: glue: " in pr_fmt().)

Well, there's a v3 already in which I don't change pr_fmt() any more:

https://lore.kernel.org/linux-acpi/[email protected]/

because acpi_handle_debug() uses it like dev_fmt() (and only if
dynamic debug is compiled in) and it looks odd when printed after the
device name (or ACPI object path).

I have a patch to clean up the acpi_handle_*() mess which will be posted later.