Re: [PATCH] alpha: add missing address argument in call to page_table_check_pte_clear()

Magnus Lindholm <[email protected]>
Newsgroups org.kernel.vger.linux-alpha,org.kernel.vger.linux-kernel
Message-ID <CA+=Fv5Q2PckE6EfyQJY-N8RMAsYG=wBkFLCB4+8pN6G5ZqWP3Q@mail.gmail.com>
On Fri, Feb 13, 2026 at 8:35 AM Thomas Weißschuh
<[email protected]> wrote:
>
> After the merge of the alpha and mm trees, this code does not compile,
> as a parameter is missing in a call to page_table_check_pte_clear().
>
> The parameter was re-added in commit d7b4b67eb6b3 ("mm/page_table_check:
> reinstate address parameter in [__]page_table_check_pte_clear()").
> The alpha-specific code was newly added in commit dd5712f3379c ("alpha:
> fix user-space corruption during memory compaction").
>
> Fixes: 4cff5c05e076 ("Merge tag 'mm-stable-2026-02-11-19-22' of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm")
> Signed-off-by: Thomas Weißschuh <[email protected]>
> ---
> This should go directly through Linus, in my opinion.
> ---
>  arch/alpha/include/asm/pgtable.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/alpha/include/asm/pgtable.h b/arch/alpha/include/asm/pgtable.h
> index c9508ec37efc..e9368c54be45 100644
> --- a/arch/alpha/include/asm/pgtable.h
> +++ b/arch/alpha/include/asm/pgtable.h
> @@ -289,7 +289,7 @@ static inline pte_t ptep_clear_flush(struct vm_area_struct *vma,
>         struct mm_struct *mm = vma->vm_mm;
>         pte_t pte = ptep_get_and_clear(mm, addr, ptep);
>
> -       page_table_check_pte_clear(mm, pte);
> +       page_table_check_pte_clear(mm, addr, pte);
>         migrate_flush_tlb_page(vma, addr);
>         return pte;
>  }
>
> ---
> base-commit: cee73b1e840c154f64ace682cb477c1ae2e29cc4
> change-id: 20260213-alpha-page_table_check_pte_clear-e583fa765111
>
> Best regards,
> --
> Thomas Weißschuh <[email protected]>
>


Hi,

Thanks alot for bringing this up! I noticed this issue yesterday when
trying to build from the latest git. This patch fixes the issue cleanly.
Sounds good to me if this goes directly through Linus, if not I can
take it through my tree, just let me know.


Acked-by: Magnus Lindholm <[email protected]>
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.