Re: [PATCH 09/25] xor: move generic implementations out of asm-generic/xor.h
"Arnd Bergmann" <[email protected]>
| Newsgroups | org.kernel.vger.linux-alpha,dev.linux.lists.loongarch,org.infradead.lists.linux-riscv,org.infradead.lists.linux-um,org.kernel.vger.linux-arch,org.kernel.vger.linux-btrfs,org.kernel.vger.linux-crypto,org.kernel.vger.linux-kernel,org.kernel.vger.linux-raid,org.kernel.vger.linux-s390,org.kernel.vger.sparclinux,org.ozlabs.lists.linuxppc-dev |
|---|---|
| Message-ID | <[email protected]> |
On Thu, Feb 26, 2026, at 16:10, Christoph Hellwig wrote: > Move the generic implementations from asm-generic/xor.h to > per-implementaion .c files in lib/raid. > > Note that this would cause the second xor_block_8regs instance created by > arch/arm/lib/xor-neon.c to be generated instead of discarded as dead > code, so add a NO_TEMPLATE symbol to disable it for this case. > > Signed-off-by: Christoph Hellwig <[email protected]> Acked-by: Arnd Bergmann <[email protected]> # for asm-generic > > -#pragma GCC diagnostic ignored "-Wunused-variable" > -#include <asm-generic/xor.h> > +#define NO_TEMPLATE > +#include "../../../lib/raid/xor/xor-8regs.c" The #include is slightly ugly, but I see it gets better in a later patch, and is clearly worth it either way. The rest of the series looks good to me as well. I had a brief look at each patch, but nothing to complain about. Arnd