Re: [PATCH v2 8/8] alpha: enable GENERIC_ENTRY and GENERIC_IRQ_ENTRY

On Fri, Jun 12, 2026 at 7:52 PM Matt Turner <[email protected]> wrote:
>
> On Fri, May 29, 2026 at 10:23 AM Magnus Lindholm <[email protected]> wrote:
> > diff --git a/arch/alpha/kernel/ptrace.c b/arch/alpha/kernel/ptrace.c
> > index 69eb337347df..d4a8937985be 100644
> > --- a/arch/alpha/kernel/ptrace.c
> > +++ b/arch/alpha/kernel/ptrace.c
> > @@ -134,18 +134,51 @@ get_reg_addr(struct task_struct * task, unsigned long regno)
> >  /*
> >   * Get contents of register REGNO in task TASK.
> >   */
> > -static unsigned long
> > -get_reg(struct task_struct * task, unsigned long regno)
> > +
> > +static bool
> > +valid_regno(unsigned long regno)
> >  {
> > -       /* Special hack for fpcr -- combine hardware and software bits.  */
> > +       switch (regno) {
> > +       case 0 ... 31:
>
> POKEUSR implements the floating-point registers, 32-62 (63 is FPCR).
> We should implement them here as well for symmetry.
>
> > +       case 63:
>
> I think we need to implement 64 (program counter). Without that, I
> think single-stepping will be broken?

Nice catch, thanks alot. I'll fix this and send out a v3. Thanks for
taking the time to test and review this.

Magnus