Re: [PATCH 0/3] vmsplice: make vmsplice a trivial wrapper for preadv2/pwritev2
Christian Brauner <[email protected]>
| Newsgroups | org.kernel.vger.linux-api,dev.linux.lists.patches,org.kernel.vger.linux-fsdevel,org.kernel.vger.linux-kernel,org.kernel.vger.netdev,org.kvack.linux-mm |
|---|---|
| Message-ID | <20260601-aufweichen-dissens-ausrechnen-0d9b84728113@brauner> |
On Mon, Jun 01, 2026 at 08:50:00AM -0700, Linus Torvalds wrote: > On Mon, 1 Jun 2026 at 08:36, Matthew Wilcox <[email protected]> wrote: > > > > Can we review this series properly? > > Well, since it pretty much is what I suggested a few years ago, I > certainly won't NAK it. > > And the patches looked very straightforward to me. Just the final > diffstat is worth quoting again because that certainly doesn't look > problematic: > > 7 files changed, 33 insertions(+), 204 deletions(-) > > and it removes that GIFT flag that was truly disgusting. > > So I'm certainly ok with it from a "looking at the patch" standpoint. > I didn't _test_ it. I don't have any workload that might remotely > care. > > I did a quick scan on debian code search for vmsplice, and after ten > pages of entries that weren't actually *using* it but had lists of > system calls, I grew bored. So there are likely users, but I don't > know what they are and how much they care. It *might* be a big > performance issue somewhere. Unlikely, but... As usual I would argue to accept it and revert in case we get actual regression reports...