Re: [PATCH 2/3] vmsplice: make vmsplice a trivial wrapper for preadv2/pwritev2
David Laight <[email protected]>
| Newsgroups | org.kernel.vger.linux-api,dev.linux.lists.patches,org.kernel.vger.linux-fsdevel,org.kernel.vger.linux-kernel,org.kernel.vger.netdev,org.kvack.linux-mm |
|---|---|
| Message-ID | <20260604100609.6b37f500@pumpkin> |
On Thu, 4 Jun 2026 00:17:36 +0300 Askar Safin <[email protected]> wrote: > Stefan Metzmacher <[email protected]>: > > Why is 'int fd' changed to 'unsigned long fd'? > > Because preadv2 and pwritev2 take "unsigned long". I want vmsplice > to be as similar as possible to preadv2 and pwritev2. Something needs to ensure that the high 32bits of the fd get masked off on 64bit systems. They can be non-zero in the register that comes from userspace. -- David > > > Should that be its own commit if the change is desired? > > Yes, possibly. But this patchset already got to next. >