Re: [PATCH v6 3/3] xfs: add support for FALLOC_FL_WRITE_ZEROES
Pankaj Raghav <[email protected]> Thu, 25 Jun 2026 14:16:11 +0200
| Newsgroups | org.kernel.vger.linux-api,org.kernel.vger.linux-fsdevel,org.kernel.vger.linux-xfs |
|---|---|
| Message-ID | <[email protected]> |
On 6/25/2026 2:12 PM, Christoph Hellwig wrote: > On Thu, Jun 25, 2026 at 07:16:47PM +0800, Zhang Yi wrote: >> I've thought about this more and feel that we need to add one more >> scenario here: >> >> 3) If the blocks at the boundaries are in dirty unwritten or in delay >> allocated state, it should be handled the same way as scenario 2. >> Additionally, before returning, we need to flush these two boundary >> blocks that have been partially zeroed, to ensure that after >> FALLOC_FL_WRITE_ZEROES, all ranges are in the written state. >> >> What do you think? > > Yes. Can you send an xfstest addition the exercises these corner > cases? > I have already created one that does a subset of these cases. I will add more and send it to the list soon! -- Pankaj