Re: [PATCH] vfs: missing inode operation should return a consistent error code

Mark Brown <[email protected]> Tue, 7 Jul 2026 15:27:07 +0100
Newsgroups	org.kernel.vger.linux-arch,org.kernel.vger.linux-fsdevel,org.kernel.vger.linux-kernel
Message-ID	<[email protected]>
On Thu, Jul 02, 2026 at 09:47:24AM +0200, Christian Brauner wrote:
> On Sun, 31 May 2026 12:49:46 +0200, Jori Koolstra wrote:
> > vfs: missing inode operation should return a consistent error code
> 
> I've stuffed this on a separate branch. Let's see whether we see any
> fallout.

I'm seeing a failure in the chdir01 LTP test on arm64, everything seems
to work fine apart from vfat:

tst_buffers.c:57: TINFO: Test is using guarded buffers
L5023tst_tmpdir.c:316: TINFO: Using /tmp/LTP_chdkVKCfH as tmpdir (tmpfs filesystem)
L5024tst_device.c:98: TINFO: Found free device 0 '/dev/loop0'
L5025tst_test.c:2047: TINFO: LTP version: 20260130
L5026tst_test.c:2050: TINFO: Tested kernel: 7.2.0-rc2-next-20260707 #1 SMP PREEMPT @1783429165 aarch64
L5027tst_kconfig.c:88: TINFO: Parsing kernel config '/proc/config.gz'
L5028tst_test.c:1875: TINFO: Overall timeout per run is 0h 00m 40s

...

tst_test.c:1985: TINFO: === Testing on vfat ===
L5158tst_test.c:1290: TINFO: Formatting /dev/loop0 with vfat opts='' extra opts=''
L5159tst_test.c:1302: TINFO: Mounting /dev/loop0 to /tmp/LTP_chdkVKCfH/mntpoint fstyp=vfat flags=0
L5160chdir01.c:85: TBROK: Cannot create symlinks: EOPNOTSUPP (95)

Looks like a changed the error code here has confused the test's feature
detection.  How many non-LTP applications have the same detection
algorithm is a separate question.

A full log may be visible at:

  https://lava.sirena.org.uk/scheduler/job/2954697#L5157

but I'm having a horrible time with AI scrapers at the minute so your
mileage may very much vary.

Bisect log:

# bad: [5c73cd9f0819c1c44e373e3dabb68318b1de1a12] Add linux-next specific files for 20260707
# good: [fc5f2284ad6951ce06d6881ca8cbd6d14d5f5071] Merge branch 'for-linux-next-fixes' of https://gitlab.freedesktop.org/drm/misc/kernel.git
# good: [42843a9ac5e809f0cc23d9c7fc4f7fc680ef533f] Merge branch 'vfs-7.3.iomap' into vfs.all
# good: [9a2e05b1fd4254f89110c9ec5efd23c838e92f1b] Merge branch 'vfs-7.3.mount' into vfs.all
# good: [526b2b2b2461704c8e8ecf7c3e514221a80ddc0d] Merge branch 'vfs-7.3.netfs' into vfs.all
# good: [5c73bf8878bf4e2770549c029ea41b328993de92] Merge branch 'vfs-7.3.kthread' into vfs.all
# good: [8abc1c8badc11c859bb4ba43211611347e59c55c] Merge patch series "Add bpf_sock_read_xattr() kfunc to read socket xattrs"
# good: [41fda7804af4931df056f74f91661edf7f696777] super: make fs_holder_ops private
# good: [fb3fcb406b8882a91d1e51bae97101802fc991e1] soc: document merges
# good: [4015411d5c76b22831d20f48abfe03754c2f41aa] Merge branch 'soc/dt' into for-next
# good: [1c996a37fd244d19e5dbb715328c1676e28ef607] tools/power turbostat: pmt: Improve sscanf() hygiene
git bisect start '5c73cd9f0819c1c44e373e3dabb68318b1de1a12' 'fc5f2284ad6951ce06d6881ca8cbd6d14d5f5071' '42843a9ac5e809f0cc23d9c7fc4f7fc680ef533f' '9a2e05b1fd4254f89110c9ec5efd23c838e92f1b' '526b2b2b2461704c8e8ecf7c3e514221a80ddc0d' '5c73bf8878bf4e2770549c029ea41b328993de92' '8abc1c8badc11c859bb4ba43211611347e59c55c' '41fda7804af4931df056f74f91661edf7f696777' 'fb3fcb406b8882a91d1e51bae97101802fc991e1' '4015411d5c76b22831d20f48abfe03754c2f41aa' '1c996a37fd244d19e5dbb715328c1676e28ef607'
# test job: [42843a9ac5e809f0cc23d9c7fc4f7fc680ef533f] https://lava.sirena.org.uk/scheduler/job/2946674
# test job: [9a2e05b1fd4254f89110c9ec5efd23c838e92f1b] https://lava.sirena.org.uk/scheduler/job/2946625
# test job: [526b2b2b2461704c8e8ecf7c3e514221a80ddc0d] https://lava.sirena.org.uk/scheduler/job/2946471
# test job: [5c73bf8878bf4e2770549c029ea41b328993de92] https://lava.sirena.org.uk/scheduler/job/2946559
# test job: [8abc1c8badc11c859bb4ba43211611347e59c55c] https://lava.sirena.org.uk/scheduler/job/2946694
# test job: [41fda7804af4931df056f74f91661edf7f696777] https://lava.sirena.org.uk/scheduler/job/2946598
# test job: [fb3fcb406b8882a91d1e51bae97101802fc991e1] https://lava.sirena.org.uk/scheduler/job/2849417
# test job: [4015411d5c76b22831d20f48abfe03754c2f41aa] https://lava.sirena.org.uk/scheduler/job/2849285
# test job: [1c996a37fd244d19e5dbb715328c1676e28ef607] https://lava.sirena.org.uk/scheduler/job/2829780
# test job: [5c73cd9f0819c1c44e373e3dabb68318b1de1a12] https://lava.sirena.org.uk/scheduler/job/2954697
# bad: [5c73cd9f0819c1c44e373e3dabb68318b1de1a12] Add linux-next specific files for 20260707
git bisect bad 5c73cd9f0819c1c44e373e3dabb68318b1de1a12
# test job: [cf6f88615485a68df77092de1f90f88708a32fa6] https://lava.sirena.org.uk/scheduler/job/2948415
# bad: [cf6f88615485a68df77092de1f90f88708a32fa6] Merge branch 'vfs-7.3.errno' into vfs.all
git bisect bad cf6f88615485a68df77092de1f90f88708a32fa6
# test job: [7028d60a643ac945826ae281ae5ec1940ee06fbf] https://lava.sirena.org.uk/scheduler/job/2948438
# bad: [7028d60a643ac945826ae281ae5ec1940ee06fbf] vfs: missing inode operation should return a consistent error code
git bisect bad 7028d60a643ac945826ae281ae5ec1940ee06fbf
# first bad commit: [7028d60a643ac945826ae281ae5ec1940ee06fbf] vfs: missing inode operation should return a consistent error code
# test job: [7028d60a643ac945826ae281ae5ec1940ee06fbf] https://lava.sirena.org.uk/scheduler/job/2948438
# bad: [7028d60a643ac945826ae281ae5ec1940ee06fbf] vfs: missing inode operation should return a consistent error code
git bisect bad 7028d60a643ac945826ae281ae5ec1940ee06fbf
# first bad commit: [7028d60a643ac945826ae281ae5ec1940ee06fbf] vfs: missing inode operation should return a consistent error code
signature.asc (application/pgp-signature, 488 B)