Re: [External] Re: [PATCH v8 1/3] riscv: io: avoid null-pointer arithmetic in PIO helpers
yunhui cui <[email protected]>
| Newsgroups | org.kernel.vger.linux-arch,dev.linux.lists.llvm,org.infradead.lists.linux-riscv,org.kernel.vger.bpf,org.kernel.vger.linux-kernel,org.kvack.linux-mm |
|---|---|
| Message-ID | <CAEEQ3wk8gK9pam2da=o5mbfzU3-5EtfH5nyhAoVfCoy+7UuCGA@mail.gmail.com> |
Hi Paul, On Tue, Jul 14, 2026 at 2:04 AM Paul Walmsley <[email protected]> wrote: > > On Fri, 3 Jul 2026, Yunhui Cui wrote: > > > When port I/O is not supported, exposing the port-string helpers is both > > unnecessary and can make clang diagnose null-pointer arithmetic from the > > PCI_IOBASE based address expression. Keep the MMIO string helpers > > available as before, but only provide the port I/O variants when > > CONFIG_HAS_IOPORT is enabled. > > > > Signed-off-by: Yunhui Cui <[email protected]> > > Reviewed-by: Arnd Bergmann <[email protected]> > > Thanks, queued for v7.2-rc. Thanks for queuing patch 1. That patch is independent and safe to take as-is. For patches 2/3, we later found that the percpu try_cmpxchg fallback path can expose a variable-shadowing issue in the current RISC-V cmpxchg macro implementation in arch/riscv/include/asm/cmpxchg.h. I'll address that in the next revision of the percpu patches, so please just take patch 1 from v8 for now. > > > - Paul Thanks, Yunhui