[PATCH v14 14/15] barrier: add tests for smp_cond_load_*_timeout()
Ankur Arora <[email protected]>
| Newsgroups | org.kernel.vger.linux-arch,org.infradead.lists.linux-arm-kernel,org.kernel.vger.bpf,org.kernel.vger.linux-kernel,org.kernel.vger.linux-pm |
|---|---|
| Message-ID | <[email protected]> |
Add success and failure case tests for smp_cond_load_*_timeout(). Success or failure cases depend on the expected bit being set (or not). Additionally in failure cases smp_cond_load_*_timeout() cannot return before timeout. Cc: Julian Braha <[email protected]> Signed-off-by: Ankur Arora <[email protected]> --- Notes: - s/BARRIER_TIMEOUT_TEST/BARRIER_TIMEOUT_KUNIT_TEST/ - limit visibility of the config option to only if CONFIG_KUNIT_ALL_TESTS is not enabled. lib/Kconfig.debug | 10 +++ lib/tests/Makefile | 1 + lib/tests/barrier-timeout-test.c | 128 +++++++++++++++++++++++++++++++ 3 files changed, 139 insertions(+) create mode 100644 lib/tests/barrier-timeout-test.c diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index 1244dcac2294..07a06cfd820a 100644 --- a/lib/Kconfig.debug +++ b/lib/Kconfig.debug @@ -2551,6 +2551,16 @@ config FFS_KUNIT_TEST For more information on KUnit and unit tests in general, please refer to Documentation/dev-tools/kunit/. +config BARRIER_TIMEOUT_KUNIT_TEST + tristate "KUnit tests for smp_cond_load_relaxed_timeout()" if !KUNIT_ALL_TESTS + depends on KUNIT + default KUNIT_ALL_TESTS + help + Builds KUnit tests that validate wake-up and timeout handling paths + in smp_cond_load_relaxed_timeout(). + + If unusure, say N. + config TEST_KSTRTOX tristate "Test kstrto*() family of functions at runtime" diff --git a/lib/tests/Makefile b/lib/tests/Makefile index 4ead57602eac..796f63c89bc2 100644 --- a/lib/tests/Makefile +++ b/lib/tests/Makefile @@ -14,6 +14,7 @@ obj-$(CONFIG_CHECKSUM_KUNIT) += checksum_kunit.o obj-$(CONFIG_CMDLINE_KUNIT_TEST) += cmdline_kunit.o obj-$(CONFIG_CPUMASK_KUNIT_TEST) += cpumask_kunit.o obj-$(CONFIG_FFS_KUNIT_TEST) += ffs_kunit.o +obj-$(CONFIG_BARRIER_TIMEOUT_KUNIT_TEST) += barrier-timeout-test.o CFLAGS_fortify_kunit.o += $(call cc-disable-warning, unsequenced) CFLAGS_fortify_kunit.o += $(call cc-disable-warning, stringop-overread) CFLAGS_fortify_kunit.o += $(call cc-disable-warning, stringop-truncation) diff --git a/lib/tests/barrier-timeout-test.c b/lib/tests/barrier-timeout-test.c new file mode 100644 index 000000000000..4226fb6456b3 --- /dev/null +++ b/lib/tests/barrier-timeout-test.c @@ -0,0 +1,128 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * KUnit tests exercising smp_cond_load_relaxed_timeout(). + * + * Copyright (c) 2026, Oracle Corp. + * Author: Ankur Arora <[email protected]> + */ + +#include <linux/bitops.h> +#include <linux/types.h> +#include <linux/sched/clock.h> +#include <linux/delay.h> +#include <asm/barrier.h> +#include <kunit/test.h> +#include <kunit/visibility.h> + +MODULE_IMPORT_NS("EXPORTED_FOR_KUNIT_TESTING"); + +struct clock_state { + s64 start_time; + s64 end_time; +}; + +#define TIMEOUT_MSEC 2 +#define TEST_FLAG_VAL BIT(2) +static unsigned int flag; + +static s64 basic_clock(struct clock_state *clk) +{ + clk->end_time = local_clock(); + return clk->end_time; +} + +static void update_flags(void) +{ + WRITE_ONCE(flag, TEST_FLAG_VAL); +} + +static s64 mocked_clock(struct clock_state *clk) +{ + s64 clk_mid = clk->start_time + (TIMEOUT_MSEC * NSEC_PER_MSEC)/2; + + clk->end_time = local_clock(); + if (clk->end_time >= clk_mid) + update_flags(); + return clk->end_time; +} + +typedef s64 (*clkfn_t)(struct clock_state *); +struct smp_cond_update_params { + clkfn_t clock; + bool acquire; + bool succeeds; +}; + +static const struct smp_cond_update_params update_params_list[] = { + /* mocked-clock updates flag inline. */ + { .clock = &mocked_clock, .succeeds = true, .acquire = false, }, + { .clock = &mocked_clock, .succeeds = true, .acquire = true, }, + + /* basic-clock doesn't update flag. */ + { .clock = &basic_clock, .succeeds = false, .acquire = true, }, + { .clock = &basic_clock, .succeeds = false, .acquire = false, }, +}; + +static void param_to_desc(const struct smp_cond_update_params *p, char *desc) +{ + char *clk, *update; + + if (p->clock == &mocked_clock) { + clk = "mocked"; + update = "inline"; + } else if (p->clock == &basic_clock) { + clk = "basic"; + update = "none"; + } + + + snprintf(desc, KUNIT_PARAM_DESC_SIZE, "smp_cond_%s_timeout: clock-%s, update=%s", + p->acquire ? "acquire" : "relaxed", clk, update); +} + +KUNIT_ARRAY_PARAM(smp_cond_update_params, update_params_list, param_to_desc); + + +static void test_smp_cond_timeout(struct kunit *test) +{ + const struct smp_cond_update_params *p = test->param_value; + struct clock_state clk = { + .start_time = local_clock(), + .end_time = local_clock(), + }; + s64 runtime, timeout_ns = TIMEOUT_MSEC * NSEC_PER_MSEC; + unsigned int result; + + flag = 0; + if (p->acquire) { + result = smp_cond_load_acquire_timeout(&flag, + (VAL & TEST_FLAG_VAL), + p->clock(&clk), + timeout_ns); + } else { + result = smp_cond_load_relaxed_timeout(&flag, + (VAL & TEST_FLAG_VAL), + p->clock(&clk), + timeout_ns); + } + + runtime = clk.end_time - clk.start_time; + KUNIT_EXPECT_EQ(test, (bool)(result & TEST_FLAG_VAL), p->succeeds); + if (!p->succeeds) + KUNIT_EXPECT_GE(test, runtime, timeout_ns); +} + +static struct kunit_case barrier_timeout_test_cases[] = { + KUNIT_CASE_PARAM(test_smp_cond_timeout, smp_cond_update_params_gen_params), + {} +}; + +static struct kunit_suite barrier_timeout_test_suite = { + .name = "smp-cond-load-*-timeout", + .test_cases = barrier_timeout_test_cases, +}; + +kunit_test_suite(barrier_timeout_test_suite); + +MODULE_DESCRIPTION("KUnit tests for smp_cond_load_relaxed_timeout()"); +MODULE_LICENSE("GPL"); -- 2.43.7