Re: [PATCH v5 1/4] mmc: Allow host driver to control the re-programming of Crypto keys
Neeraj Soni <[email protected]>
| Newsgroups | org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-kernel,org.kernel.vger.linux-mmc |
|---|---|
| Message-ID | <[email protected]> |
On 7/31/2026 12:33 AM, Eric Biggers wrote:
> On Thu, Jul 30, 2026 at 07:38:19PM +0530, Neeraj Soni wrote:
>> diff --git a/include/linux/mmc/host.h b/include/linux/mmc/host.h
>> index ba84f02c2a10..83d92fb64417 100644
>> --- a/include/linux/mmc/host.h
>> +++ b/include/linux/mmc/host.h
>> @@ -457,12 +457,9 @@ struct mmc_host {
>> #define MMC_CAP2_CQE_DCMD (1 << 24) /* CQE can issue a direct command */
>> #define MMC_CAP2_AVOID_3_3V (1 << 25) /* Host must negotiate down from 3.3V */
>> #define MMC_CAP2_MERGE_CAPABLE (1 << 26) /* Host can merge a segment over the segment size */
>> -#ifdef CONFIG_MMC_CRYPTO
>> #define MMC_CAP2_CRYPTO (1 << 27) /* Host supports inline encryption */
>> -#else
>> -#define MMC_CAP2_CRYPTO 0
>> -#endif
>
> I'm still a bit confused why this unrelated change is included. If
> you'd like to make this unrelated change, it should be a separate patch,
> and the mtk-sd patch would need to be before it (not after).
>
This was included as part of clean up suggested by Konrad for
MMC_CAP2_CRYPTO_NO_REPROG here https://lore.kernel.org/linux-mmc/[email protected]/
but i understand that this is unrelated to this patch series.
I will revert this in v6.
> - Eric
>
Regards,
Neeraj