Re: [PATCH 3/3] watchdog: qcom: Register pretimeout interrupt as NMI
Guenter Roeck <[email protected]>
| Newsgroups | org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-kernel,org.kernel.vger.linux-watchdog |
|---|---|
| Message-ID | <[email protected]> |
On 7/31/26 04:56, Konrad Dybcio wrote: > On 7/30/26 11:32 PM, Mayank Rungta via B4 Relay wrote: >> From: Mayank Rungta <[email protected]> >> >> When a system is completely unresponsive due to an interrupt storm or >> deadlocked CPU cores with standard interrupts disabled, a standard watchdog >> pretimeout bark interrupt will fail to execute, preventing the pretimeout >> governor from capturing CPU backtraces before the hardware reset bite. > > [...] > >> drivers/watchdog/qcom-wdt.c | 55 +++++++++++++++++++++++++++++++++++++++++---- >> 1 file changed, 51 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/watchdog/qcom-wdt.c b/drivers/watchdog/qcom-wdt.c >> index 49bd04841f0c..19d8e91cff40 100644 >> --- a/drivers/watchdog/qcom-wdt.c >> +++ b/drivers/watchdog/qcom-wdt.c >> @@ -51,6 +51,9 @@ struct qcom_wdt { >> unsigned long rate; >> void __iomem *base; >> const u32 *layout; >> + int irq; >> + bool is_nmi; >> + bool irq_enabled; > > Do we need to track this? I think we can rely on the framework > NOPing out multiple ops->start requests > Good point. Agreed. Guenter