Re: [PATCH 01/28] dt-bindings: phy: qcom: Describe QMP USB and UFS PHY vdda-phy/vdda-pll voltages

Krzysztof Kozlowski <[email protected]> Tue, 4 Aug 2026 10:36:33 +0200
Newsgroups org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel
Message-ID <20260804-lemon-malamute-from-nibiru-eeedde@quoll>
On Mon, Aug 03, 2026 at 08:33:59AM +0200, Manivannan Sadhasivam wrote:
> The vdda-phy and vdda-pll supplies of the QMP USB and UFS PHYs are
> frequently swapped in devicetrees, as the naming does not make clear
> which supply expects which voltage. Document that vdda-phy is around
> 0.8V and vdda-pll is around 1.2V, with the exact voltage varying per
> SoC, so that the correct supplies can be assigned.
> 
> Reported-by: Konrad Dybcio <[email protected]>
> Assisted-by: Claude:opus-4-8
> Signed-off-by: Manivannan Sadhasivam <[email protected]>
> ---
>  .../devicetree/bindings/phy/qcom,msm8998-qmp-usb3-phy.yaml   | 10 ++++++++--
>  .../devicetree/bindings/phy/qcom,qcs615-qmp-usb3dp-phy.yaml  | 10 ++++++++--
>  .../devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml   | 12 +++++++++---
>  .../bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml         | 12 +++++++++---
>  .../bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml          | 10 ++++++++--
>  5 files changed, 42 insertions(+), 12 deletions(-)

Reviewed-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof