Re: [PATCH v14 1/9] firmware: qcom_scm: ipq5332: add support to pass metadata size

Varadarajan Narayanan <[email protected]> Tue, 4 Aug 2026 16:53:48 +0530

Newsgroups	org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel,org.kernel.vger.linux-remoteproc
Message-ID	<[email protected]>

Mukesh,

[ . . . ]

> >  	if (IS_ERR(gunyah_wdt_dev)) {
> > -		dev_err(scm->dev, "Failed to register Gunyah watchdog device: %ld\n",
> > +		dev_err(scm->dev, "Failed to register Gunyah watchdog device: %pe\n",
>
> stray change..

Based on AI feedhack changed %ld to %pe to print PTR_ERR.

Thanks
Varada

> >  			PTR_ERR(gunyah_wdt_dev));
> >  		return;
> >  	}
> > diff --git a/drivers/firmware/qcom/qcom_scm.h b/drivers/firmware/qcom/qcom_scm.h
> > index cf90a565fdfb..e58c76aba45c 100644
> > --- a/drivers/firmware/qcom/qcom_scm.h
> > +++ b/drivers/firmware/qcom/qcom_scm.h
> > @@ -105,6 +105,7 @@ int qcom_scm_shm_bridge_enable(struct device *scm_dev);
> >  #define QCOM_SCM_PIL_PAS_SHUTDOWN	0x06
> >  #define QCOM_SCM_PIL_PAS_IS_SUPPORTED	0x07
> >  #define QCOM_SCM_PIL_PAS_MSS_RESET	0x0a
> > +#define QCOM_SCM_PIL_PAS_INIT_IMAGE_V2	0x1a
> >  #define QCOM_SCM_PIL_PAS_GET_RSCTABLE	0x21
> >
> >  #define QCOM_SCM_SVC_IO			0x05
> >
> > --
> > 2.34.1
> >
>
> Otherwise, looks fine.
>
> Reviewed-by: Mukesh Ojha <[email protected]>
>
> --
> -Mukesh Ojha