Re: [PATCH 14/28] arm64: dts: qcom: sm7225-fairphone-fp4: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
"Luca Weiss" <[email protected]> Tue, 04 Aug 2026 15:26:44 +0200
| Newsgroups | org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On Mon Aug 3, 2026 at 8:34 AM CEST, Manivannan Sadhasivam via B4 Relay wrote: > From: Manivannan Sadhasivam <[email protected]> > > The QMP PHY expects the vdda-phy supply to be around 0.88V and the > vdda-pll supply to be 1.2V. But these two supplies are swapped for the > USB QMP PHY on this board, feeding 1.2V to vdda-phy and 0.9V to > vdda-pll. > > Fix it by swapping the two supplies back. > > Fixes: 4cbea668767d ("arm64: dts: qcom: sm7225: Add device tree for Fairphone 4") > Reported-by: Konrad Dybcio <[email protected]> > Assisted-by: Claude:opus-4-8 > Signed-off-by: Manivannan Sadhasivam <[email protected]> > --- > arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts b/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts > index 23f950067a08..bea82cbc2c88 100644 > --- a/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts > +++ b/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts > @@ -1247,8 +1247,8 @@ &usb_1_hsphy { > }; > > &usb_1_qmpphy { > - vdda-phy-supply = <&vreg_l22a>; > - vdda-pll-supply = <&vreg_l16a>; > + vdda-phy-supply = <&vreg_l16a>; > + vdda-pll-supply = <&vreg_l22a>; Schematics confirm: * VREG_L16A_0P88 <-> VDD_A_USBSSDP_0P9 * VREG_L22A_1P2 <-> VDD_A_USBSSDP_1P2 So this also matches. Reviewed-by: Luca Weiss <[email protected]> > > status = "okay"; > };