Re: [PATCH 1/4] watchdog: qcom: Propagate errors from optional IRQ lookup
Guenter Roeck <[email protected]>
| Newsgroups | org.kernel.vger.linux-arm-msm,org.infradead.lists.linux-arm-kernel,org.infradead.lists.linux-mediatek,org.kernel.vger.linux-kernel,org.kernel.vger.linux-watchdog,org.ozlabs.lists.linux-aspeed |
|---|---|
| Message-ID | <[email protected]> |
On 8/8/26 01:59, Bui Duc Phuc wrote:
> Hi Guenter,
>
> Thanks for the review.
>
>>
>> This is wrong. Check the if() path - the code ends up here if pretimeout == 0,
>> even if irq > 0.
>>
>
> You're right. I misunderstood the condition in the if() path.
> I'll rewrite it as follows:
>
> irq = platform_get_irq_optional(pdev, 0);
> +if (irq < 0 && irq != -ENXIO)
> + return irq;
This is still wrong. If there is no pretimeout, it does not matter if there is an error.
Guenter
> if (data->pretimeout && irq > 0) {
> .....
> } else {
> - if (irq == -EPROBE_DEFER)
> - return -EPROBE_DEFER;
> wdt->wdd.info = &qcom_wdt_info;
> }
>
> Best regards,
> Phuc