Re: [PATCH 1/2] arm64: dts: qcom: hamoa-iot-evk: Add eDP display overlay
Dmitry Baryshkov <[email protected]>
| Newsgroups | org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <eblai4d6apohd43uvo4kbm3y6yfkso7rd643ijra2awyguve5l@j7aq2vzzwmj2> |
On Fri, Aug 07, 2026 at 03:30:13PM +0530, Anand Tiwari wrote: > On Thu, Aug 06, 2026 at 07:05:37PM -0500, Bjorn Andersson wrote: > > On Thu, Aug 06, 2026 at 10:01:20PM +0530, Anand Tiwari wrote: > > > Move the eDP panel configuration and related power, backlight, and pinctrl > > > nodes into a separate overlay. Keep the base DTB suitable for headless > > > variants and provide a composite DTB for headed variants. > > > > To quote: > > https://docs.kernel.org/process/submitting-patches.html#describe-your-changes > > > > """ > > Describe your problem. Whether your patch is a one-line bug fix or 5000 > > lines of a new feature, there must be an underlying problem that > > motivated you to do this work. Convince the reviewer that there is a > > problem worth fixing and that it makes sense for them to read past the > > first paragraph. > > """ > > > > In fact, I'm not even able to guess what the problem you're fixing here. > > > > Regards, > > Bjorn > > > > The problem is that the base device trees currently describe the eDP > display hardware unconditionally. However, Hamoa and Purwa IoT EVKs > are also available in headless variants without an eDP panel. > > With current base DTBs, headless variants are not stable where eDP panel is not > physically connected with board and userspace is trying to use it. Please define "are not stable" > This series fixes the inaccurate hardware description by keeping the > base DTBs limited to hardware common to both variants and moving the > eDP-specific nodes into separate overlays. The base DTB can therefore > be used for headless variants, while the overlay is selected for > headed variants. -- With best wishes Dmitry