Re: [PATCH 0/5] arm64: dts: qcom: clean up PCI function nodes
Manivannan Sadhasivam <[email protected]>
| Newsgroups | org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <fr4v6eqc3bynt3klrdutkh5rwpueieqdtleqwjy32dkatzvbdb@jxjn3chegxlv> |
On Fri, Aug 07, 2026 at 02:58:39PM -0500, Alex Elder wrote: > While working on upstream support for the Toshiba TC9564 SoC I > learned that its PCIe endpoint function nodes included the > device_type property, indicating each is a "pci" device. Herve > Codina pointed out that this is not correct; only a PCI device > "that implements a PCI bus" should define that property. > > I looked at other upstream devicetree files and I found four other > places with this same mistake. (All are for Qualcomm platforms, > and all are for platforms using a TC956x SoC.) > > This series removes the device_type property where it is defined > for a PCI endpoint function. > > It also removes the #address-cells, #size-cells, and ranges > properties in these cases, with a plan to restore them only when > they are known to be needed (to implement pci-ep-bus sub-nodes). Thanks for cleaning the mess! Reviewed-by: Manivannan Sadhasivam <[email protected]> - Mani -- மணிவண்ணன் சதாசிவம்