Re: [PATCH 4/4] arm64: dts: qcom: Add Retroid Pocket Nova

On Thu, Aug 13, 2026 at 4:24 AM Krzysztof Kozlowski <[email protected]> wrote:
>
> On Sat, Aug 08, 2026 at 12:37:58PM -0500, Aaron Kling wrote:
> > The Retroid Pocket Nova is a high-performance Android-based handheld
> > gaming console powered by the Qualcomm Snapdragon 8 Gen 2 processor
> > featuring a 4.5-inch 4:3 AMOLED touchscreen.
> >
> > Signed-off-by: Aaron Kling <[email protected]>
> > ---
> >  arch/arm64/boot/dts/qcom/Makefile                  |   1 +
> >  .../boot/dts/qcom/qcs8550-retroidpocket-nova.dts   | 118 +++++++++++++++++++++
> >  2 files changed, 119 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
> > index 09b3c5b2d9dab..582805e89f4cb 100644
> > --- a/arch/arm64/boot/dts/qcom/Makefile
> > +++ b/arch/arm64/boot/dts/qcom/Makefile
> > @@ -196,6 +196,7 @@ dtb-$(CONFIG_ARCH_QCOM)   += qcs8550-aim300-aiot.dtb
> >  dtb-$(CONFIG_ARCH_QCOM)      += qcs8550-ayntec-odin2mini.dtb
> >  dtb-$(CONFIG_ARCH_QCOM)      += qcs8550-ayntec-odin2portal.dtb
> >  dtb-$(CONFIG_ARCH_QCOM)      += qcs8550-ayntec-thor.dtb
> > +dtb-$(CONFIG_ARCH_QCOM)      += qcs8550-retroidpocket-nova.dtb
> >  dtb-$(CONFIG_ARCH_QCOM)      += qcs8550-retroidpocket-rp6.dtb
> >  dtb-$(CONFIG_ARCH_QCOM)      += qcs8550-rb5gen2.dtb
> >  dtb-$(CONFIG_ARCH_QCOM)      += qcs9100-ride.dtb
> > diff --git a/arch/arm64/boot/dts/qcom/qcs8550-retroidpocket-nova.dts b/arch/arm64/boot/dts/qcom/qcs8550-retroidpocket-nova.dts
> > new file mode 100644
> > index 0000000000000..10dabb1d51f5a
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/qcom/qcs8550-retroidpocket-nova.dts
> > @@ -0,0 +1,118 @@
> > +// SPDX-License-Identifier: BSD-3-Clause
> > +
> > +/dts-v1/;
> > +
> > +#include <dt-bindings/gpio/gpio.h>
> > +#include <dt-bindings/interrupt-controller/irq.h>
> > +#include "qcs8550-ayntec-common.dtsi"
> > +
> > +&{/} {
> > +     model = "Retroid Pocket Nova";
> > +     compatible = "retroidpocket,nova", "qcom,qcs8550", "qcom,sm8550";
> > +
> > +     backlight: backlight {
> > +             compatible = "pwm-backlight";
> > +             pwms = <&pmk8550_pwm 0 860000>;
> > +             brightness-levels = <1023 0>;
> > +             num-interpolated-steps = <1023>;
> > +             default-brightness-level = <600>;
> > +             power-supply = <&vph_pwr>;
> > +             enable-gpios = <&pmk8550_gpios 5 GPIO_ACTIVE_HIGH>;
> > +             pinctrl-names = "default";
> > +             pinctrl-0 = <&pwm_backlight_default>;
> > +
> > +             status = "okay";
> > +     };
> > +
> > +     vdd_disp_1v8: vdd-disp-1v8-regulator {
>
> So foo-regulator?
>
> > +             compatible = "regulator-fixed";
> > +             regulator-name = "vdd_disp_1v8";
> > +
> > +             regulator-min-microvolt = <1800000>;
> > +             regulator-max-microvolt = <1800000>;
> > +
> > +             gpio = <&tlmm 70 GPIO_ACTIVE_HIGH>;
> > +             enable-active-high;
> > +     };
> > +
> > +     vdd_disp_2v8: vdd-disp-2v8-regulator {
> > +             compatible = "regulator-fixed";
> > +             regulator-name = "vdd_disp_2v8";
> > +
> > +             regulator-min-microvolt = <2800000>;
> > +             regulator-max-microvolt = <2800000>;
> > +
> > +             gpio = <&tlmm 142 GPIO_ACTIVE_HIGH>;
> > +             enable-active-high;
> > +     };
> > +
> > +     ts_avdd_3v0: regulator-ts-avdd-3v0 {
>
> Or regulator-foo?

Given that the associated AYN series uses foo-regulator, it makes more
sense to me to remain consistent with that. The question has been
raised on the RP6 patch in this series, so I will wait for a response
there before sending a new revision.

> Decide and also read:
> https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml

Ack.

> Best regards,
> Krzysztof

Aaron