Re: [PATCH 3/4] arm64: dts: qcom: Add Retroid Pocket 6

On Fri, Aug 14, 2026 at 01:59:55PM -0500, Aaron Kling wrote:
> On Thu, Aug 13, 2026 at 2:06 PM Dmitry Baryshkov
> <[email protected]> wrote:
> >
> > On Sat, Aug 08, 2026 at 12:37:57PM -0500, Aaron Kling via B4 Relay wrote:
> > > From: Aaron Kling <[email protected]>
> > >
> > > The Retroid Pocket 6 is a high-performance Android-based handheld gaming
> > > console powered by the Qualcomm Snapdragon 8 Gen 2 processor featuring a
> > > 5.5-inch AMOLED touchscreen.
> > >
> > > This is based on the support by ROCKNIX, however their history does not
> > > show who the original author was, so direct attributation cannot be
> > > given.
> > >
> > > Signed-off-by: Aaron Kling <[email protected]>
> > > ---
> > >  arch/arm64/boot/dts/qcom/Makefile                  |   1 +
> > >  .../boot/dts/qcom/qcs8550-retroidpocket-rp6.dts    | 122 +++++++++++++++++++++
> > >  2 files changed, 123 insertions(+)
> > >
> > > +
> > > +     vdd_disp_1v8: vdd-disp-1v8-regulator {
> >
> > regulator-foo
> 
> I see these are inconsistent, I missed that when pulling the support
> in. However, looking at the associated AYN series, all regulators are
> named foo-regulator. Using regulator-foo would make that inconsistent,
> is that really desired?


I think, it's generally a better ide. Feel free to rename the regulator
nodes in the existing DTs that you import in a spearate patch (although
that might get rejected by other reviewers as "noise").

> 
> > > +             compatible = "regulator-fixed";
> > > +             regulator-name = "vdd_disp_1v8";
> > > +
> > > +             regulator-min-microvolt = <1800000>;
> > > +             regulator-max-microvolt = <1800000>;
> > > +
> > > +             gpio = <&tlmm 70 GPIO_ACTIVE_HIGH>;
> > > +             enable-active-high;
> > > +     };
> > > +
> > > +     vdd_disp_2v8: vdd-disp-2v8-regulator {
> > > +             compatible = "regulator-fixed";
> > > +             regulator-name = "vdd_disp_2v8";
> > > +
> > > +             regulator-min-microvolt = <2800000>;
> > > +             regulator-max-microvolt = <2800000>;
> > > +
> > > +             gpio = <&tlmm 142 GPIO_ACTIVE_HIGH>;
> > > +             enable-active-high;
> > > +     };
> > > +
> > > +     ts_avdd_3v0: regulator-ts-avdd-3v0 {
> > > +             compatible = "regulator-fixed";
> > > +             regulator-name = "ts_avdd_3v0";
> > > +
> > > +             regulator-min-microvolt = <3000000>;
> > > +             regulator-max-microvolt = <3000000>;
> > > +
> > > +             gpio = <&tlmm 144 GPIO_ACTIVE_HIGH>;
> > > +             enable-active-high;
> > > +     };
> > > +
> > > +     ts_vddio_1v8: regulator-ts-vddio-1v8 {
> > > +             compatible = "regulator-fixed";
> > > +             regulator-name = "ts_vddio_1v8";
> > > +
> > > +             regulator-min-microvolt = <1800000>;
> > > +             regulator-max-microvolt = <1800000>;
> > > +
> > > +             gpio = <&tlmm 102 GPIO_ACTIVE_HIGH>;
> > > +             enable-active-high;
> > > +     };
> > > +};
> > > +
> > > +&mdss_dsi1 {
> >
> > Out of place.
> 
> Oops.
> 
> > > +     status = "disabled";
> >
> > Isn't this a default? If so, no need to repeat it.
> 
> qcs8550-ayntec-common.dtsi enables this because most of the variants
> have a panel on this connector. So as one of the odd ones out, this
> needs turned back off.

Yep, I missed it. THanks for the pointer.

> 
> > > +};
> > > +
> > > +&i2c_hub_3 {
> > > +     clock-frequency = <100000>;
> > > +
> > > +     status = "okay";
> > > +
> > > +     touchscreen@38 {
> > > +             compatible = "focaltech,ft5426";
> > > +             reg = <0x38>;
> > > +
> > > +             interrupt-parent = <&tlmm>;
> > > +             interrupts = <15 IRQ_TYPE_EDGE_FALLING>;
> > > +             reset-gpios = <&tlmm 14 GPIO_ACTIVE_LOW>;
> > > +
> > > +             vcc-supply = <&ts_avdd_3v0>;
> > > +             iovcc-supply = <&ts_vddio_1v8>;
> > > +
> > > +             pinctrl-0 = <&ts_p_rst_default &ts_p_int_default>;
> > > +             pinctrl-1 = <&ts_p_rst_sleep &ts_p_int_sleep>;
> > > +             pinctrl-names = "default", "sleep";
> > > +
> > > +             touchscreen-size-x = <1080>;
> > > +             touchscreen-size-y = <1920>;
> > > +             touchscreen-swapped-x-y;
> > > +     };
> > > +};
> > > +
> > > +&pmk8550_pwm {
> > > +     status = "okay";
> > > +};
> > > +
> > > +&remoteproc_adsp {
> > > +     firmware-name = "qcom/sm8550/retroidpocket/rp6/adsp.mbn",
> > > +                     "qcom/sm8550/retroidpocket/rp6/adsp_dtb.mbn";
> > > +
> > > +     status = "okay";
> > > +};
> > > +
> > > +&spk_amp_l {
> > > +     firmware-name = "qcom/sm8550/retroidpocket/rp6/aw883xx_acf.bin";
> > > +};
> > > +
> > > +&spk_amp_r {
> > > +     firmware-name = "qcom/sm8550/retroidpocket/rp6/aw883xx_acf.bin";
> > > +};
> > >
> > > --
> > > 2.54.0
> > >
> > >
> >
> > --
> > With best wishes
> > Dmitry
> 
> Aaron

-- 
With best wishes
Dmitry