Re: [PATCH] arm64: dts: qcom: ipq5018: Add pinctrl for MDIO bus
Konrad Dybcio <[email protected]>
| Newsgroups | org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On 8/11/26 3:36 PM, Luo Jie wrote: > The external MDIO bus (mdio1) needs its MDC/MDIO lines configured via > TLMM pinctrl; without this the pins are left in their default state and > the bus does not function on boards that enable it. > > Add a mdio_pins pinctrl state for gpio36 (mdc) and gpio37 (mdio) with > 8mA drive strength and pull-up, and reference it from the mdio1 node > via pinctrl-0/pinctrl-names. This paragraph is a bit heavy on repeating the diff contents (could be just "Add the missing states and reference them." instead), but overall this looks good Reviewed-by: Konrad Dybcio <[email protected]> Konrad